impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.
Date Thu, 14 Sep 2017 16:57:30 GMT
Philip Zeyliger has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/8070

Change subject: IMPALA-5908: Allow SET to unset modified query options.
......................................................................

IMPALA-5908: Allow SET to unset modified query options.

The query 'SET <option>=""' will now unset option, reverting it to
its default state.

This change became necessary with "SET" started returning an
empty string for unset options which don't have a default. The test
infrastructure (impala_test_suite.py) resets options to what it
thinks is its defaults, and, when this broke, some ASAN builds
started to fail, presumably due to a timing issue with how
we re-use connections between tests.

Testing:
* Added a simple test that triggered this side-effect without this code.
  Specifically, "impala-python infra/python/env/bin/py.test tests/metadata/test_set.py -s"
  with the modified set.test triggers.
* Added cases to query-options-test to check behavior for both
  defaulted and non-defaulted values.
* Ran an ASAN build where this was triggering previously.

Change-Id: Ia8c383e68064f839cb5000118901dff77b4e5cb9
---
M be/src/service/query-options-test.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M testdata/workloads/functional-query/queries/QueryTest/set.test
M tests/common/impala_test_suite.py
5 files changed, 483 insertions(+), 425 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/8070/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8c383e68064f839cb5000118901dff77b4e5cb9
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Philip Zeyliger <philip@cloudera.com>

Mime
View raw message