impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tianyi Wang (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4987: Fix flaky test test row availability.py
Date Tue, 12 Sep 2017 01:56:03 GMT
Tianyi Wang has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/8036

Change subject: IMPALA-4987: Fix flaky test test_row_availability.py
......................................................................

IMPALA-4987: Fix flaky test test_row_availability.py

This patch keeps test_row_availbility from random failure. In this test
the time interval between 'Rows available' event and the previous event
in runtime profile is measured in order to make sure that rows become
available after a specific amount of time. This is not correct since
the previous event is that the coordinator finishes sending query to
backends, which means the execution on backend might have already
started. This patch tracks another event "ready to start" as the
beginning of time interval instead. The coordinator begins to send
query to backends after this event so the time check should always pass.

Change-Id: I96142f1868a26426cbc34aa9a0e0a56979df66c3
---
M tests/query_test/test_rows_availability.py
1 file changed, 30 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/8036/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I96142f1868a26426cbc34aa9a0e0a56979df66c3
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>

Mime
View raw message