impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tianyi Wang (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5597: Check predicate children types when building runtime filter plan
Date Sat, 02 Sep 2017 00:15:55 GMT
Tianyi Wang has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7949

Change subject: IMPALA-5597: Check predicate children types when building runtime filter plan
......................................................................

IMPALA-5597: Check predicate children types when building runtime filter plan

This patch fixes a bug that fails a precondition check when generating
runtime filter plans. The lhs and rhs of predicate to be joined on may
have different types when the eq predicate function accepts
wildcard-typed parameters. Then in existing code the types of source
and target expr will be found mismatch and an exception will be thrown.
With this patch such runtime filters are abandoned.
A testcase is added to joins.test

Change-Id: I0d66673e280ce13cd3a514236c0c2ecbc50475a6
---
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
M testdata/workloads/functional-query/queries/QueryTest/joins.test
2 files changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/7949/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d66673e280ce13cd3a514236c0c2ecbc50475a6
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>

Mime
View raw message