impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Armstrong <tarmstr...@cloudera.com>
Subject Re: [Impala-ASF-CR] [DOCS] Explain Boost setting needed for 96-bit timestamps
Date Tue, 12 Sep 2017 17:17:32 GMT
I've been talking to John out of band about this. I had some more meta
concerns about documenting this and whether it will encourage customers to
do dangerous things. Need to organise my thoughts and enumerate concerns.

On 12 Sep. 2017 9:42 am, "Matthew Jacobs (Code Review)" <gerrit@cloudera.org>
wrote:

> Matthew Jacobs has posted comments on this change.
>
> Change subject: [DOCS] Explain Boost setting needed for 96-bit timestamps
> ......................................................................
>
>
> Patch Set 2:
>
> (3 comments)
>
> http://gerrit.cloudera.org:8080/#/c/7983/2/docs/shared/impala_common.xml
> File docs/shared/impala_common.xml:
>
> PS2, Line 848: our
> who is 'our' here?
>
>
> PS2, Line 850: ,
>              :         which matches the representation for
> <codeph>TIMESTAMP</codeph> in Impala
> , and is required in order to use TIMESTAMP.
>
>
> Line 855: <codeblock>
> it might be good to just say that you should probably just define this
> variable always, unless you have a really good reason not to
>
>
> --
> To view, visit http://gerrit.cloudera.org:8080/7983
> To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I4b67cd7762f682c3a054e0d9641080aa51801c83
> Gerrit-PatchSet: 2
> Gerrit-Project: Impala-ASF
> Gerrit-Branch: master
> Gerrit-Owner: John Russell <jrussell@cloudera.com>
> Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
> Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
> Gerrit-Reviewer: Michael Ho
> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
> Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
> Gerrit-HasComments: Yes
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message