impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] PREVIEW: IMPALA-5307: Part 4: copy out uncompressed text and seq
Date Fri, 29 Sep 2017 23:51:31 GMT
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8172 )

Change subject: PREVIEW: IMPALA-5307: Part 4: copy out uncompressed text and seq
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/8172/1/be/src/exec/exec-node.h
File be/src/exec/exec-node.h:

http://gerrit.cloudera.org:8080/#/c/8172/1/be/src/exec/exec-node.h@109
PS1, Line 109:   /// Caller must not be holding any io buffers. This will cause deadlock.
> Remove - not relevant even before this patch
Done


http://gerrit.cloudera.org:8080/#/c/8172/1/be/src/exec/hdfs-scanner.h
File be/src/exec/hdfs-scanner.h:

http://gerrit.cloudera.org:8080/#/c/8172/1/be/src/exec/hdfs-scanner.h@99
PS1, Line 99: /// resources (IO buffers and mem pools) to the current row batch, and passing
row batches
> Needs update
Done


http://gerrit.cloudera.org:8080/#/c/8172/1/be/src/runtime/row-batch.h
File be/src/runtime/row-batch.h:

http://gerrit.cloudera.org:8080/#/c/8172/1/be/src/runtime/row-batch.h@218
PS1, Line 218:   /// make it consistent between buffers and I/O buffers.
> Needs update
Done


http://gerrit.cloudera.org:8080/#/c/8172/1/be/src/runtime/row-batch.h@254
PS1, Line 254:   /// pool and io buffers.
> needs update
Done


http://gerrit.cloudera.org:8080/#/c/8172/1/be/src/runtime/row-batch.h@275
PS1, Line 275:   /// Acquires state from the 'src' row batch into this row batch. This includes
all IO
> Needs update
Done


http://gerrit.cloudera.org:8080/#/c/8172/1/be/src/runtime/row-batch.h@397
PS1, Line 397:   /// Sum of all auxiliary bytes. This includes IoBuffers and memory from
> Old reference to IoBuffers. Can probably rename to total_buffer_bytes_ or s
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8172
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I304fd002b61bfedf41c8b1405cd7eb7b492bb941
Gerrit-Change-Number: 8172
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Sep 2017 23:51:31 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message