impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Sherman (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer
Date Fri, 29 Sep 2017 23:48:59 GMT
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/7061 )

Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer
......................................................................


Patch Set 8:

No problem, I just got back from a month long wedding/honeymoon myself.

I'll try to address your comments in the next few days.

 > (3 comments)
 > 
 > Sorry for the slow response and thanks for your patience, John.
 > Henry is away on holiday, but let's try to get this in in the
 > meantime. The patch looks good to me. I just have a couple small
 > comments. And rebasing the patch before posting the next patch set
 > would be a good idea.


-- 
To view, visit http://gerrit.cloudera.org:8080/7061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a5f3d9cf931cff14eae7f236fea018236a6255
Gerrit-Change-Number: 7061
Gerrit-PatchSet: 8
Gerrit-Owner: John Sherman <jfs@arcadiadata.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: John Sherman <jfs@arcadiadata.com>
Gerrit-Reviewer: Matthew Jacobs <mjacobs@apache.org>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Comment-Date: Fri, 29 Sep 2017 23:48:59 +0000
Gerrit-HasComments: No

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message