impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.
Date Fri, 29 Sep 2017 00:34:21 GMT
Tim Armstrong has posted comments on this change. ( )

Change subject: IMPALA-5908: Allow SET to unset modified query options.

Patch Set 7:

File be/src/service/impala-server.h:
PS10, Line 347:     TQueryOptions *server_default_query_options;
nit: placement of *
File be/src/service/impala-server.h:
PS7, Line 306:   struct SessionState {
This "struct' is pretty out of control. I agree with your earlier comment that this should
be a class, particularly since it has non-trivial locking rules.

I don't think we need to do that cleanup now though.
File be/src/service/
PS7, Line 134: NULL
nullptr (we still have NULL all over the codebase but we're gradually switching).
File be/src/service/
PS10, Line 61: 
Ahh we've seen this mistake a few times before.
PS10, Line 83:  
nit: placement of *
File common/thrift/ImpalaInternalService.thrift:
PS10, Line 86: 
a what?
File tests/custom_cluster/
PS10, Line 25: class TestSetAndUnset(CustomClusterTestSuite, HS2TestSuite):
Thanks for adding this, clearly there was a gap in test coverage here.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8c383e68064f839cb5000118901dff77b4e5cb9
Gerrit-Change-Number: 8070
Gerrit-PatchSet: 7
Gerrit-Owner: Philip Zeyliger <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Philip Zeyliger <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Comment-Date: Fri, 29 Sep 2017 00:34:21 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message