impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5940: Avoid log spew by using Status::Expected.
Date Fri, 29 Sep 2017 00:07:02 GMT
Dan Hecht has posted comments on this change. ( )

Change subject: IMPALA-5940: Avoid log spew by using Status::Expected.

Patch Set 3:

File be/src/exec/
PS3, Line 972:       return Status::Expected(Substitute(
Michael/Tim - these will show up in the runtime profile still, right? so okay to avoid logging
them, right?
File be/src/runtime/client-cache.h:
PS3, Line 243:         string err = strings::Substitute("Client $0 timed-out during recv call.",
long line
PS3, Line 246:         return Status::Expected(ErrorMsg(TErrorCode::RPC_RECV_TIMEOUT, err));
Michael/Sailesh - are you guys okay with eliminating this backtrace, or have we found it useful
for debugging in the field?
PS3, Line 281:         return Status::Expected(ErrorMsg(TErrorCode::RPC_RECV_TIMEOUT, err));
same set of comment/question
File be/src/runtime/
PS3, Line 309:       stringstream ss;
             :       ss << "Could not codegen CodegenMaterializeExprs: " << status.GetDetail();
okay to ignore, but could clean that up with Substitute()

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I38088482377a1c3e794a9c8178ef83f29957a330
Gerrit-Change-Number: 8100
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Zeyliger <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Mostafa Mokhtar <>
Gerrit-Reviewer: Philip Zeyliger <>
Gerrit-Comment-Date: Fri, 29 Sep 2017 00:07:02 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message