impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5986: Correct set-option logic to recognize digits in names.
Date Thu, 28 Sep 2017 19:15:14 GMT
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8166
)

Change subject: IMPALA-5986: Correct set-option logic to recognize digits in names.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8166/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/8166/1/tests/common/impala_test_suite.py@103
PS1, Line 103: SET_PATTERN = re.compile(r'\s*set\s*([a-zA-Z_][a-zA-Z0-9_]*)\s*=*', re.I)
> This is a slightly ticklish philo. question for me.  I'm not opposed to rem
I don't think it matters much, so I'll leave it to your discretion. We can update the comment
above it to point out that it matches the IDL. Specifically "alphabets and underscores" is
no longer true.



-- 
To view, visit http://gerrit.cloudera.org:8080/8166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3ba641553ff827dbd4673b9fe7ed7d9d5e83052
Gerrit-Change-Number: 8166
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wood <twood@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Sep 2017 19:15:14 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message