impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Wood (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5986: Correct set-option logic to recognize digits in names.
Date Thu, 28 Sep 2017 18:48:25 GMT
Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8166 )

Change subject: IMPALA-5986: Correct set-option logic to recognize digits in names.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8166/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

http://gerrit.cloudera.org:8080/#/c/8166/1/tests/common/impala_test_suite.py@103
PS1, Line 103: SET_PATTERN = re.compile(r'\s*set\s*([a-zA-Z_][a-zA-Z0-9_]*)\s*=*', re.I)
> Since this is a case insensitive RE (re.I), I think you don't need the A-Z 
This is a slightly ticklish philo. question for me.  I'm not opposed to removing A-Z, but
this pattern (which does seem to match the Thrift grammar for Identifier) is so iconic to
people by now, that the missing A-Z might give one pause before seeing the re.I.  This way,
the pattern can be lifted into a context that doesn't use (or have) ignore-case matching (like
bash, apparently).  We still need the re.I for the SET keyword.



-- 
To view, visit http://gerrit.cloudera.org:8080/8166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3ba641553ff827dbd4673b9fe7ed7d9d5e83052
Gerrit-Change-Number: 8166
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wood <twood@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Sep 2017 18:48:25 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message