impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4736: Add SIGUSR1 bahavior to help string for 'minidump path' flag
Date Thu, 28 Sep 2017 17:41:01 GMT
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8164 )

Change subject: IMPALA-4736: Add SIGUSR1 bahavior to help string for 'minidump_path' flag
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8164/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8164/1//COMMIT_MSG@7
PS1, Line 7: bahavior
behavior


http://gerrit.cloudera.org:8080/#/c/8164/1/be/src/common/global-flags.cc
File be/src/common/global-flags.cc:

http://gerrit.cloudera.org:8080/#/c/8164/1/be/src/common/global-flags.cc@103
PS1, Line 103: requested by "
             :     "user (SIGUSR1)
maybe it's worth spelling out a bit more - something like "requested by sending a SIGUSR1
signal to the process"



-- 
To view, visit http://gerrit.cloudera.org:8080/8164
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f4da8ff12c10e4a84a339ddb4036d1682b3a2a0
Gerrit-Change-Number: 8164
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <csringhofer@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Sep 2017 17:41:01 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message