impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Wood (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.
Date Wed, 27 Sep 2017 01:41:08 GMT
Tim Wood has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/8140 )

Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.
......................................................................

IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

Main source for TPCDS query and result definitions: https://github.com/gregrahn/tpcds-kit.
TPC-DS v2.5.0 qualification queries from G. Rahn, Cloudera, Inc.
Data set constructed in mini-cluster using $IMPALA_HOME/buildall.sh -testdata....
This commit continues previous work on IMPALA-5376 in the ASF Impala repo
and the Cloudera Gerrit service.

This commit splits multi-query tests in the TPC-DS suite definition into one
query and result set per test file, as the test framework requires.  Names for
such files have -1, -2... inner suffixes.

The complete TPC-DS test suite runs with passes, skips and xfails,
but no failures, as reflected by runs of
$IMPALA_HOME/tests/run-tests.py query_test/test_tpcds_queries.py ...
Expected result sets come from the TPC-DS kit.  Some TPC-DS test cases
in this commit have been modified in sematically-neutral ways so as to pass
on Impala; others are marked to skip or xfail due to bugs.  Tests that flap
are marked to skip, with a bug ID, since they don't reliably pass or xfail.
The tests/query_test/test_tpcds_queries.py driver file is authoritative for the
active/skip/xfail status for each case and a brief reason.  The following list
describes the current status as:
--- test-name
deviance from TPC-DS spec
changes made

--- tpcds-q22a.test
RESULT MISMATCH in LSD of AVG() values
Fixed AVG()s
--- tpcds-q30.test
UNRECOGNIZED CHARACTER
MARKED XFAIL, IMPALA-5961.
--- tpcds-q31.test
RESULT MISMATCH in LSD of DECIMAL values
ADDED TRUNCATE(2)s AROUND LAST 4 COLUMNS. MARKED SKIP, IMPALA-5956
--- tpcds-q35a.test
RESULT MISMATCH
MARKED XFAIL, IMPALA-5950.
--- tpcds-q36a.test
RESULT MISMATCH
MARKED XFAIL, IMPALA-4741
--- tpcds-q39.test
MULTIPLE RESULT SET not recognized by test framework
MARKED XFAIL.
--- tpcds-q47.test
RESULT MISMATCH in LSD of DECIMAL values
ADDED TRUNCATE(2) TO 8th COLUMN OF WITH TABLE, TAKE ACTUAL RESULT AS EXPECTED.
--- tpcds-q49.test
RESULT MISMATCH in LSD of DECIMAL values
MARKED XFAIL, IMPALA-5945
--- tpcds-q57.test
RESULT MISMATCH, excess scale in DECIMAL values
FIXED, ADDED TRUNCATE(2) AROUND 6th COLUMN.
--- tpcds-q58.test
RESULT MISMATCH in DECIMAL values
MARKED XFAIL. IMPALA-5946
--- tpcds-q59.test
RESULT MISMATCH, excess scale in DECIMAL values
FIXED, ADDED TRUNCATE(2) AROUND 4th-10th COLUMNS.
--- tpcds-q61.test
RESULT MISMATCH in DECIMAL value
FIXED. CAST RESULT QUOTIENT TO DECIMAL(15, 4), TAKE ACTUAL RESULT AS EXPECTED
--- tpcds-q63.test
RESULT MISMATCH, excess scale in DECIMAL values
ADDED TRUNCATE(2) TO 3rd COLUMN
--- tpcds-q64.test
RESULT MISMATCH
ADDED ORDER BY COLUMNS.
--- tpcds-q66.test
RESULT MISMATCH
MARKED XFAIL, IMPALA-4741
--- tpcds-q77a.test
RESULT MISMATCH
FIXED. TAKE ACTUAL RESULT AS EXPECTED
--- tpcds-q78.test
RESULT MISMATCH
FIXED. TAKE ACTUAL RESULT AS EXPECTED
--- tpcds-q83.test
RESULT MISMATCH
MARKED XFAIL. IMPALA-5945.
--- tpcds-q85.test
MISSING TABLE "reason"
MARKED XFAIL, IMPALA-5960
--- tpcds-q86a.test
RESULT MISMATCH
FIXED. TAKE ACTUAL RESULT AS EXPECTED
--- tpcds-q89.test
RESULT MISMATCH, DECIMAL values flap
MARKED XFAIL. ADDED ROUND(2) TO 8th COLUMN, TAKE ACTUAL RESULTS AS EXPECTED, IMPALA-5956.
--- tpcds-q90.test
RESULT MISMATCH
MARKED XFAIL, IMPALA-5945.
--- tpcds-q93.test
MISSING TABLE "reason"
MARKED XFAIL, IMPALA-5960
--- tpcds-q98.test
RESULT MISMATCH
FIXED, ADDED ROUND() TO LAST COLUMN

IMPALA-5986: Allow SET option names to contain digits when resetting them between queries.

Change-Id: I026a0123b035b6828ef35b599dda50aadf0171bb
---
A testdata/workloads/tpcds/queries/tpcds-q10.test
A testdata/workloads/tpcds/queries/tpcds-q10a.test
A testdata/workloads/tpcds/queries/tpcds-q11.test
A testdata/workloads/tpcds/queries/tpcds-q12.test
A testdata/workloads/tpcds/queries/tpcds-q13.test
A testdata/workloads/tpcds/queries/tpcds-q14-1.test
A testdata/workloads/tpcds/queries/tpcds-q14-2.test
A testdata/workloads/tpcds/queries/tpcds-q14a-1.test
A testdata/workloads/tpcds/queries/tpcds-q14a-2.test
A testdata/workloads/tpcds/queries/tpcds-q15.test
A testdata/workloads/tpcds/queries/tpcds-q16.test
A testdata/workloads/tpcds/queries/tpcds-q17.test
A testdata/workloads/tpcds/queries/tpcds-q18.test
A testdata/workloads/tpcds/queries/tpcds-q18a.test
A testdata/workloads/tpcds/queries/tpcds-q20.test
A testdata/workloads/tpcds/queries/tpcds-q21.test
A testdata/workloads/tpcds/queries/tpcds-q22.test
A testdata/workloads/tpcds/queries/tpcds-q22a.test
M testdata/workloads/tpcds/queries/tpcds-q23-1.test
M testdata/workloads/tpcds/queries/tpcds-q23-2.test
A testdata/workloads/tpcds/queries/tpcds-q24-1.test
A testdata/workloads/tpcds/queries/tpcds-q24-2.test
A testdata/workloads/tpcds/queries/tpcds-q25.test
A testdata/workloads/tpcds/queries/tpcds-q26.test
M testdata/workloads/tpcds/queries/tpcds-q27a.test
M testdata/workloads/tpcds/queries/tpcds-q28.test
A testdata/workloads/tpcds/queries/tpcds-q29.test
A testdata/workloads/tpcds/queries/tpcds-q30.test
A testdata/workloads/tpcds/queries/tpcds-q31.test
A testdata/workloads/tpcds/queries/tpcds-q32.test
A testdata/workloads/tpcds/queries/tpcds-q33.test
A testdata/workloads/tpcds/queries/tpcds-q35.test
A testdata/workloads/tpcds/queries/tpcds-q35a.test
A testdata/workloads/tpcds/queries/tpcds-q36.test
A testdata/workloads/tpcds/queries/tpcds-q36a.test
A testdata/workloads/tpcds/queries/tpcds-q37.test
A testdata/workloads/tpcds/queries/tpcds-q38.test
A testdata/workloads/tpcds/queries/tpcds-q39-1.test
A testdata/workloads/tpcds/queries/tpcds-q39-2.test
A testdata/workloads/tpcds/queries/tpcds-q40.test
A testdata/workloads/tpcds/queries/tpcds-q41.test
A testdata/workloads/tpcds/queries/tpcds-q44.test
A testdata/workloads/tpcds/queries/tpcds-q45.test
M testdata/workloads/tpcds/queries/tpcds-q47.test
A testdata/workloads/tpcds/queries/tpcds-q48.test
A testdata/workloads/tpcds/queries/tpcds-q49.test
A testdata/workloads/tpcds/queries/tpcds-q5.test
A testdata/workloads/tpcds/queries/tpcds-q50.test
A testdata/workloads/tpcds/queries/tpcds-q51.test
A testdata/workloads/tpcds/queries/tpcds-q51a.test
A testdata/workloads/tpcds/queries/tpcds-q54.test
A testdata/workloads/tpcds/queries/tpcds-q56.test
A testdata/workloads/tpcds/queries/tpcds-q57.test
A testdata/workloads/tpcds/queries/tpcds-q58.test
M testdata/workloads/tpcds/queries/tpcds-q59.test
A testdata/workloads/tpcds/queries/tpcds-q5a.test
A testdata/workloads/tpcds/queries/tpcds-q60.test
M testdata/workloads/tpcds/queries/tpcds-q61.test
A testdata/workloads/tpcds/queries/tpcds-q62.test
M testdata/workloads/tpcds/queries/tpcds-q63.test
A testdata/workloads/tpcds/queries/tpcds-q64.test
A testdata/workloads/tpcds/queries/tpcds-q66.test
A testdata/workloads/tpcds/queries/tpcds-q67.test
A testdata/workloads/tpcds/queries/tpcds-q67a.test
A testdata/workloads/tpcds/queries/tpcds-q69.test
A testdata/workloads/tpcds/queries/tpcds-q70.test
A testdata/workloads/tpcds/queries/tpcds-q70a.test
A testdata/workloads/tpcds/queries/tpcds-q71.test
A testdata/workloads/tpcds/queries/tpcds-q72.test
A testdata/workloads/tpcds/queries/tpcds-q74.test
A testdata/workloads/tpcds/queries/tpcds-q75.test
A testdata/workloads/tpcds/queries/tpcds-q76.test
A testdata/workloads/tpcds/queries/tpcds-q77.test
A testdata/workloads/tpcds/queries/tpcds-q77a.test
A testdata/workloads/tpcds/queries/tpcds-q78.test
M testdata/workloads/tpcds/queries/tpcds-q8.test
A testdata/workloads/tpcds/queries/tpcds-q80.test
A testdata/workloads/tpcds/queries/tpcds-q80a.test
A testdata/workloads/tpcds/queries/tpcds-q81.test
A testdata/workloads/tpcds/queries/tpcds-q82.test
A testdata/workloads/tpcds/queries/tpcds-q83.test
A testdata/workloads/tpcds/queries/tpcds-q84.test
A testdata/workloads/tpcds/queries/tpcds-q85.test
A testdata/workloads/tpcds/queries/tpcds-q86.test
A testdata/workloads/tpcds/queries/tpcds-q86a.test
A testdata/workloads/tpcds/queries/tpcds-q87.test
M testdata/workloads/tpcds/queries/tpcds-q89.test
A testdata/workloads/tpcds/queries/tpcds-q9.test
A testdata/workloads/tpcds/queries/tpcds-q90.test
A testdata/workloads/tpcds/queries/tpcds-q91.test
A testdata/workloads/tpcds/queries/tpcds-q92.test
A testdata/workloads/tpcds/queries/tpcds-q93.test
A testdata/workloads/tpcds/queries/tpcds-q94.test
A testdata/workloads/tpcds/queries/tpcds-q95.test
A testdata/workloads/tpcds/queries/tpcds-q97.test
M testdata/workloads/tpcds/queries/tpcds-q98.test
A testdata/workloads/tpcds/queries/tpcds-q99.test
M tests/common/impala_test_suite.py
M tests/query_test/test_tpcds_queries.py
99 files changed, 12,749 insertions(+), 1,472 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/8140/4
-- 
To view, visit http://gerrit.cloudera.org:8080/8140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I026a0123b035b6828ef35b599dda50aadf0171bb
Gerrit-Change-Number: 8140
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Wood <twood@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message