impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.
Date Fri, 22 Sep 2017 21:58:21 GMT
David Knupp has posted comments on this change. ( )

Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

Patch Set 5:

(1 comment)
Commit Message:
PS5, Line 12: This commit continues previous work on IMPALA-5376 under the apache/incubator-impala
            : on, and commit 6877 at
> Done
Hope this isn't just me being a pest, but when I look at IMPALA-5376 on the Apache JIRA server,
there's simply nothing there indicating that an initial patch (adding all of the missing tables)
was earlier committed by Michael Ho. I prefer to have it explicitly stated this is a follow-on
to that earlier patch. The last suggestion in this regard was to reference the first patch
by its title, "IMPALA-5376: Loads all TPC-DS tables," rather than using a transient gerrit
or github identifier.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e284888600a7a69d1f23fcb7dac21cbb13b7d66
Gerrit-Change-Number: 8102
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Wood <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: David Knupp <>
Gerrit-Reviewer: Matthew Mulder <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Mostafa Mokhtar <>
Gerrit-Reviewer: Tim Wood <>
Gerrit-Comment-Date: Fri, 22 Sep 2017 21:58:21 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message