impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3360: Codegen inserting into runtime filters
Date Fri, 22 Sep 2017 21:35:01 GMT
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8029
)

Change subject: IMPALA-3360: Codegen inserting into runtime filters
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/8029/2/be/src/exec/filter-context.cc
File be/src/exec/filter-context.cc:

http://gerrit.cloudera.org:8080/#/c/8029/2/be/src/exec/filter-context.cc@216
PS2, Line 216: 
> Forgot in the previous pass: can you include an example of the IR it genera
Done


http://gerrit.cloudera.org:8080/#/c/8029/2/be/src/exec/filter-context.cc@217
PS2, Line 217: Status FilterContext::CodegenInsert(
> So I've been working on this, but it turns out to be tricky. I uploaded a n
After much discussion with Tim, we've decided not to bother trying to do the cross-compilation
and to just stick with the ir builder version.

The reason basically is that the Function returned by ScalarExpr::GetCodegendComputeFn() can't
quite be used as a drop-in replacement for ScalarExprEvaluator::GetValue() (the first returns
the value directly while the second returns a pointer) and the work necessary to fix this
without losing efficiency is beyond the scope of this patch.


http://gerrit.cloudera.org:8080/#/c/8029/2/be/src/exec/partitioned-hash-join-builder.cc
File be/src/exec/partitioned-hash-join-builder.cc:

http://gerrit.cloudera.org:8080/#/c/8029/2/be/src/exec/partitioned-hash-join-builder.cc@935
PS2, Line 935: Status PhjBuilder::CodegenInsertRuntimeFilters(
> It would be good to have an example of the IR here too.
Done


http://gerrit.cloudera.org:8080/#/c/8029/2/be/src/util/bloom-filter-ir.cc
File be/src/util/bloom-filter-ir.cc:

http://gerrit.cloudera.org:8080/#/c/8029/2/be/src/util/bloom-filter-ir.cc@24
PS2, Line 24: IR_ALWAYS_INLINE
> Is the always_inline needed here?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8029
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79cf23ad92dadaab996a50a2ca07ef9ebe8639bb
Gerrit-Change-Number: 8029
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mjacobs@apache.org>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Sep 2017 21:35:01 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message