impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Tauber-Marshall (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-3360: Codegen inserting into runtime filters
Date Fri, 22 Sep 2017 21:35:01 GMT
Thomas Tauber-Marshall has posted comments on this change. (

Change subject: IMPALA-3360: Codegen inserting into runtime filters

Patch Set 2:

File be/src/exec/
PS2, Line 216: 
> Forgot in the previous pass: can you include an example of the IR it genera
PS2, Line 217: Status FilterContext::CodegenInsert(
> So I've been working on this, but it turns out to be tricky. I uploaded a n
After much discussion with Tim, we've decided not to bother trying to do the cross-compilation
and to just stick with the ir builder version.

The reason basically is that the Function returned by ScalarExpr::GetCodegendComputeFn() can't
quite be used as a drop-in replacement for ScalarExprEvaluator::GetValue() (the first returns
the value directly while the second returns a pointer) and the work necessary to fix this
without losing efficiency is beyond the scope of this patch.
File be/src/exec/
PS2, Line 935: Status PhjBuilder::CodegenInsertRuntimeFilters(
> It would be good to have an example of the IR here too.
File be/src/util/
> Is the always_inline needed here?

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79cf23ad92dadaab996a50a2ca07ef9ebe8639bb
Gerrit-Change-Number: 8029
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Philip Zeyliger <>
Gerrit-Reviewer: Thomas Tauber-Marshall <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-Comment-Date: Fri, 22 Sep 2017 21:35:01 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message