impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Wood (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.
Date Fri, 22 Sep 2017 21:23:26 GMT
Tim Wood has posted comments on this change. ( )

Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.

Patch Set 6:


Updates to PS 5.
Commit Message:
PS5, Line 11: $IMPALA_HOME/ -te
> Nit: is in the root of Impala, not bin/
PS5, Line 12: This commit continues previous work on IMPALA-5376 in the ASF Impala repo
            : and the Cloudera Gerrit service.
> Not sure this is needed. You reference IMPALA-5376 in the commit title appr
I think it's important to mention the previous work, but I'm removing the hard identifiers.
PS5, Line 15: ery tests in the
> Can you explain in the commit message how you made the decision to have pas
PS5, Line 17: 
> Can you file a follow on Jira for the stress test (project: IMPALA; compone
Filed IMPALA-5970.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e284888600a7a69d1f23fcb7dac21cbb13b7d66
Gerrit-Change-Number: 8102
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Wood <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: David Knupp <>
Gerrit-Reviewer: Matthew Mulder <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Mostafa Mokhtar <>
Gerrit-Reviewer: Tim Wood <>
Gerrit-Comment-Date: Fri, 22 Sep 2017 21:23:26 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message