impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR](asf-site) Change log for 2.10.0 release
Date Fri, 22 Sep 2017 17:56:22 GMT
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8079 )

Change subject: Change log for 2.10.0 release
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8079/2/impala-docs.html
File impala-docs.html:

http://gerrit.cloudera.org:8080/#/c/8079/2/impala-docs.html@a148
PS2, Line 148: 
> Just curious, any particular reason? (Apart from the Google search presenti
I think it was just that, but this chat was from a long time ago. I realize there are other
ways to get around that.

...

On a personal note, I like that when the docs get updated in place, you get a clean diff that
highlights the changes, like this:

https://gerrit.cloudera.org/#/c/7397/

It would be nice to retain such a diff even if we decide to do what you propose, and I would
request we have workflows in place so that we get to see that.  It's too easy to end up with
cases where there is a lot of left-side pink and right-side green, making it harder to spot
meaningful differences.



-- 
To view, visit http://gerrit.cloudera.org:8080/8079
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d47cf805205b25861e38d106412bb7f892016a0
Gerrit-Change-Number: 8079
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Sep 2017 17:56:22 +0000
Gerrit-HasComments: Yes

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message