impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet
Date Fri, 22 Sep 2017 03:45:28 GMT
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8117
)

Change subject: IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet
......................................................................

IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet

Testing:
========
Ran core tests

Perf:
====
Ran this query a few times:

  set num_nodes=1;
  set mt_dop=1;
  select min(l_returnflag), min(l_linestatus) from biglineitem;
  summary;

I saw a speedup in scan time from ~2.25s -> 2.11s on my machine.

Change-Id: I04fb4ca73978d0100e1eb9835b87d37540b8b645
Reviewed-on: http://gerrit.cloudera.org:8080/8117
Reviewed-by: Lars Volker <lv@cloudera.com>
Reviewed-by: Dan Hecht <dhecht@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exec/parquet-column-readers.cc
1 file changed, 31 insertions(+), 8 deletions(-)

Approvals:
  Lars Volker: Looks good to me, but someone else must approve
  Dan Hecht: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I04fb4ca73978d0100e1eb9835b87d37540b8b645
Gerrit-Change-Number: 8117
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message