impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala
Date Thu, 21 Sep 2017 20:50:20 GMT
Dan Hecht has posted comments on this change. ( )

Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala

Patch Set 5:

File be/src/exprs/
PS2, Line 332:   StringVal result(context, 10);
why does this DCHECK no longer make sense?  are we saying it's trivially true now after check
HasDate() and with the checks you've added in this commit?
File be/src/runtime/timestamp-value.h:
PS4, Line 173: boost::gregorian::date
i think it would be best to avoid running the constructor given these things can throw exceptions,
so let's use 'const &' here.
PS4, Line 287:  
nit: extraneous space
File be/src/runtime/timestamp-value.h:
PS2, Line 86:   /// Constructors that parse from a date/time string. See TimestampParser for
> I think it would be better to do the logging on the caller side, because de
Logging in the caller is fine but I don't see that added to your diff.

To view, visit
To unsubscribe, visit

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77b2f6284d3a597f57e61c17a67c959eff9e38ff
Gerrit-Change-Number: 7954
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <>
Gerrit-Reviewer: Csaba Ringhofer <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Comment-Date: Thu, 21 Sep 2017 20:50:20 +0000
Gerrit-HasComments: Yes

  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message