impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Remove unused MemPool::peak allocated bytes
Date Thu, 21 Sep 2017 20:48:00 GMT
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8114
)

Change subject: Remove unused MemPool::peak_allocated_bytes_
......................................................................

Remove unused MemPool::peak_allocated_bytes_

The value is not used for anything but there is code devoted to updating
it and testing the value.

Testing:
Ran mem-pool-test to confirm it still works.

Change-Id: I99eba01869914c1d1e0a6ed0cab039d904fecc02
Reviewed-on: http://gerrit.cloudera.org:8080/8114
Reviewed-by: anujphadke <aphadke@cloudera.com>
Reviewed-by: Dan Hecht <dhecht@cloudera.com>
Tested-by: Tim Armstrong <tarmstrong@cloudera.com>
---
M be/src/runtime/mem-pool-test.cc
M be/src/runtime/mem-pool.cc
M be/src/runtime/mem-pool.h
3 files changed, 2 insertions(+), 32 deletions(-)

Approvals:
  anujphadke: Looks good to me, but someone else must approve
  Dan Hecht: Looks good to me, approved
  Tim Armstrong: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8114
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I99eba01869914c1d1e0a6ed0cab039d904fecc02
Gerrit-Change-Number: 8114
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>

Mime
  • Unnamed multipart/alternative (inline, 8-Bit, 0 bytes)
View raw message