impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5954: Set DO NOT UPDATE STATS in alterTable() RPCs to HMS.
Date Wed, 20 Sep 2017 21:00:12 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-5954: Set DO_NOT_UPDATE_STATS in alterTable() RPCs to HMS.
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8112/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

Line 800:       // HMS requires this param for stats changes to take effect.
> I checked the Hive/HMS code carefully and partition-level stat are not affe
Thanks for explaining. I agree.


PS1, Line 822: }
             :     // HMS requires this param for stats changes to take effect.
> Setting this flag is required for for stats changes to take effect (table o
Sorry, I got confused. I now see how all this works.


-- 
To view, visit http://gerrit.cloudera.org:8080/8112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05c63315579d66efeaa4c65105372ae68820ab2f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message