impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Knupp (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.
Date Wed, 20 Sep 2017 19:44:53 GMT
David Knupp has posted comments on this change.

Change subject: IMPALA-5376: Implement all TPCDS test cases or alternates for Impala.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8102/1//COMMIT_MSG
Commit Message:

Line 11: Data set constructed in mini-cluster using incubator-impala/bin/buildall.sh -testdata....
I think this sentence is awkward. "incubator-impala" happens to be what the directory is called
on your system. I suspect that most people have renamed their local directories to "Impala."
A better choice would be ${IMPALA_HOME}/bin/etc...

I also think it might be helpful to reference this patch, although I'm not sure which link
preferable. Yo might want to solicit opinions on that.
https://github.com/apache/incubator-impala/commit/f1558957
http://gerrit.cloudera.org:8080/6877


-- 
To view, visit http://gerrit.cloudera.org:8080/8102
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e284888600a7a69d1f23fcb7dac21cbb13b7d66
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Wood <twood@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Tim Wood <twood@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message