impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5927: Fix enable distcc for zsh
Date Wed, 20 Sep 2017 01:35:57 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5927: Fix enable_distcc for zsh
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8049/3/bin/clean.sh
File bin/clean.sh:

Line 33: pushd ${IMPALA_HOME}/ext-data-source
> Some of these are still missing quotes
Thank you for catching these. I had only fixed the {}.


Line 35: ${IMPALA_HOME}/bin/mvn-quiet.sh clean
> Here
Done


Line 40: pushd ${IMPALA_FE_DIR}
> Here too.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/8049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88284e4f68c309bb46ce4b5a842ccc576cd487ed
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message