impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5860: upgrade to LLVM 3.9.1
Date Wed, 20 Sep 2017 01:30:26 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5860: upgrade to LLVM 3.9.1
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7974/9/.clang-tidy
File .clang-tidy:

Line 27: -clang-analyzer-cplusplus.NewDeleteLeaks,\
> I'm concerned that some of these went in with only self-review. Some of the
I didn't remove any coverage and the suppressed warnings were mostly special cases or variants
of ones that are already suppressed (e.g. new/delete is the same as the malloc one that's
suppressed).

I looked at the output of the warnings and they didn't turn up anything helpful so IMO not
worth putting time into.


-- 
To view, visit http://gerrit.cloudera.org:8080/7974
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida873ddb15e393b0bd37486db24add8a32f43ad0
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message