impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5927: Fix enable distcc for zsh
Date Wed, 20 Sep 2017 01:29:10 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5927: Fix enable_distcc for zsh
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8049/2//COMMIT_MSG
Commit Message:

Line 12: This change makes zsh temporarily emulate sh to make enable_distcc work
> Update
Done


http://gerrit.cloudera.org:8080/#/c/8049/2/bin/clean.sh
File bin/clean.sh:

Line 77: $IMPALA_HOME/bin/clean-cmake.sh
> nit: maybe quote "$IMPALA_HOME" for consistency
I cleaned up the file. Do you want to have another look?


-- 
To view, visit http://gerrit.cloudera.org:8080/8049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88284e4f68c309bb46ce4b5a842ccc576cd487ed
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message