impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5920: Remove admission control dependency on YARN RM jar
Date Mon, 18 Sep 2017 20:43:25 GMT
Philip Zeyliger has posted comments on this change.

Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8035/3/common/yarn-extras/pom.xml
File common/yarn-extras/pom.xml:

Line 23:   <groupId>org.apache.impala</groupId>
I think we should move the implementing classes here to "org.apache.impala" as well, as opposed
to leaving them in org.apache.hadoop. This is a fairly mechanical change, but it'll make it
explicit that we've copied these over, and it'll avoid the unfortunate bugs we'd see if two
copies of one of the classes appeared on the CLASSPATH, and we didn't know which one was active.


-- 
To view, visit http://gerrit.cloudera.org:8080/8035
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7efdd8ebea298836ca2a82c0a4ae037ac9285bcf
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mjacobs@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mjacobs@apache.org>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message