impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe McDonnell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh
Date Fri, 15 Sep 2017 17:18:21 GMT
Joe McDonnell has posted comments on this change.

Change subject: IMPALA-5941: Fix Metastore schema creation in create-test-configuration.sh
......................................................................


Patch Set 1:

(1 comment)

We have had it this way for a very long time, so I'm kicking off some Jenkins jobs to test
data load.

http://gerrit.cloudera.org:8080/#/c/8081/1/bin/create-test-configuration.sh
File bin/create-test-configuration.sh:

Line 99:        -f ${HIVE_HOME}/scripts/metastore/upgrade/postgres/hive-schema-1.1.0.postgres.sql
> Very minor comment: it might be simpler to use a relative path here and avo
Fixed, that is definitely cleaner. I tested it on my box and it seems to work.


-- 
To view, visit http://gerrit.cloudera.org:8080/8081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic312df4597c7d211d4ecd551d572f751aea0cd24
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message