impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.
Date Fri, 15 Sep 2017 02:51:46 GMT
Hello Bharath Vissapragada, Tim Armstrong,

I'd like you to reexamine a change.  Please visit

to look at the new patch set (#3).

Change subject: IMPALA-5908: Allow SET to unset modified query options.

IMPALA-5908: Allow SET to unset modified query options.

The query 'SET <option>=""' will now unset option, reverting it to
its default state.

This change became necessary with "SET" started returning an
empty string for unset options which don't have a default. The test
infrastructure ( resets options to what it
thinks is its defaults, and, when this broke, some ASAN builds
started to fail, presumably due to a timing issue with how
we re-use connections between tests.

* Added a simple test that triggered this side-effect without this code.
  Specifically, "impala-python infra/python/env/bin/py.test tests/metadata/ -s"
  with the modified set.test triggers.
* Added cases to query-options-test to check behavior for both
  defaulted and non-defaulted values.
* Ran an ASAN build where this was triggering previously.

Change-Id: Ia8c383e68064f839cb5000118901dff77b4e5cb9
M be/src/service/
M be/src/service/
M be/src/service/query-options.h
M common/thrift/ImpalaInternalService.thrift
M testdata/workloads/functional-query/queries/QueryTest/set.test
M tests/common/
6 files changed, 63 insertions(+), 4 deletions(-)

  git pull ssh:// refs/changes/70/8070/3
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia8c383e68064f839cb5000118901dff77b4e5cb9
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Philip Zeyliger <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Philip Zeyliger <>
Gerrit-Reviewer: Tim Armstrong <>

View raw message