impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3877: support unpatched LLVM
Date Fri, 15 Sep 2017 00:24:59 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3877: support unpatched LLVM
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7973/2/be/src/codegen/codegen-util.h
File be/src/codegen/codegen-util.h:

PS2, Line 34: when calling functions from a linked module because the LLVM linker likes to
            :   /// merge struct types in unpredictable ways during linking.
> that's gonna be a bit hard for people to figure out, I think. is there a JI
There isn't really a JIRA since I rolled this in with the LLVM 3.8 upgrade. I expanded on
the comment here to give a concrete example - hopefully that helps.


-- 
To view, visit http://gerrit.cloudera.org:8080/7973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3dfbe44ed8a1464b9b0991fd54e72b194ad6155d
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message