impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pranay Singh (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1649 Pass precision to Print TCounterType::DOUBLE VALUE
Date Thu, 14 Sep 2017 21:55:22 GMT
Pranay Singh has posted comments on this change.

Change subject: IMPALA-1649 Pass precision to Print TCounterType::DOUBLE_VALUE
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7725/2/be/src/util/pretty-printer.h
File be/src/util/pretty-printer.h:

PS2, Line 142:       case TUnit::DOUBLE_VALUE: {
             :         double output = static_cast<double>(value);
             :         ss << std::setprecision(precision) << output << "
";
> I thought of removing TUnit::DOUBLE_VALUE from the code and replacing it wi
I see that below values displayed in Runtime profile marked as --> are of type TUnit::DOUBLE
changing over to TUnit::UNIT will affect their display.


    HDFS_SCAN_NODE (id=0):(Total: 179.334ms, non-child: 179.334ms, % non-child: 100.00%)
         - AverageHdfsReadThreadConcurrency: 0.00 -->
         - AverageScannerThreadConcurrency: 0.00  --->

        Hdfs split stats (<volume id>:<# splits>/<split lengths>): 0:24/478.45
KB 
         - AverageThreadTokens: 0.00 -->
         - BloomFilterBytes: 0

         File Formats: TEXT/NONE:24 
           - AverageHdfsReadThreadConcurrency: 0.00 -->
           - AverageScannerThreadConcurrency: 0.00 --> TUnit::DOUBLE


-- 
To view, visit http://gerrit.cloudera.org:8080/7725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc63d8a59bdf175341097df143798fb1a957d93f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Pranay Singh
Gerrit-HasComments: Yes

Mime
View raw message