impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects
Date Thu, 14 Sep 2017 21:05:10 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/7731/3/common/thrift/CatalogInternalService.thrift
File common/thrift/CatalogInternalService.thrift:

PS3, Line 34: updated
> does "updated" also include new objects? or is it really just objects that 
It includes both added and changed objects. I updated the comment but let me know if you have
a better name option.


http://gerrit.cloudera.org:8080/#/c/7731/3/common/thrift/StatestoreService.thrift
File common/thrift/StatestoreService.thrift:

PS3, Line 86: deleted
> in this case, what is in 'value'? Is it defined to be set or is only the ke
What I tried to explain in the commit msg (let me know if it still unclear) was that we should
not use the contents of "value" to indicate if a topic item is deleted or not. It doesn't
mean that a topic item with deleted set to true should have a specific value, i.e. each topic
can have a separate behavior.


PS3, Line 103: all changes
> your commit message seems to contradict that.  Oh, maybe i'm confusing cata
Hm, sorry for the confusion. What the commit is describing is related to catalog versions
and the follow up changes for fixing IMPALA-5058.


PS3, Line 105: The from_version will always be 0 for non-delta updates
> what about to_version in this case?
The to_version is 0 only when there are no changes in the topic. It's value doesn't depend
on whether the update is delta or not.


-- 
To view, visit http://gerrit.cloudera.org:8080/7731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I93cb7a033dc8f0d3e0339394b36affe14523274c
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercegovac@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message