impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4786: Clean up how ImpalaServers are created
Date Thu, 14 Sep 2017 17:58:39 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4786: Clean up how ImpalaServers are created
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7673/2/be/src/runtime/exec-env.cc
File be/src/runtime/exec-env.cc:

PS2, Line 212: LOG(INFO) << "Starting global services";
that should probably be updated


http://gerrit.cloudera.org:8080/#/c/7673/2/be/src/service/impala-server.h
File be/src/service/impala-server.h:

Line 1006:   boost::shared_ptr<ThriftServer> be_server_;
why do we need shared ptrs for these? can we not have single ownership?


-- 
To view, visit http://gerrit.cloudera.org:8080/7673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d55fbe0f4f7a1fd48993da46863b66e521feaae
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message