impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options
Date Thu, 14 Sep 2017 16:12:15 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5736: Add impala-shell argument to set default query options
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8038/1/shell/option_parser.py
File shell/option_parser.py:

PS1, Line 160:   parser.add_option("--var", dest="keyval", action="append",
             :                     help="Define variable(s) to be used within the Impala session."
             :                          " It must follow the pattern \"KEY=VALUE\","
             :                          " KEY starts with an alphabetic character and"
             :                          " contains alphanumeric characters or underscores.")
             :   parser.add_option("--query_options", dest="query_options",
             :                     help="Sets default query options. The format is comma separated"
             :   
> We have talked about this with Lars, and decided to stick with the comma se
My thinking was that we already follow the k=v,k=v syntax for tools like start-impala-cluster.py.
However I see how consistency with --var is a nice thing to have and I'm ok with picking that
route.


-- 
To view, visit http://gerrit.cloudera.org:8080/8038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26a3b67230c80a99bd246b6af205d558fec9a986
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Csaba Ringhofer <csringhofer@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringhofer@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message