impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Csaba Ringhofer (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options
Date Thu, 14 Sep 2017 13:30:41 GMT
Csaba Ringhofer has posted comments on this change.

Change subject: IMPALA-5736: Add impala-shell argument to set default query options
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8038/1//COMMIT_MSG
Commit Message:

PS1, Line 16: .impalarc:
            : [impala]
            : query_options=EXPLAIN_LEVEL=2,MT_DOP=2
> This might be hard to do, but I think
I think that it would be easier to do it like this:
[impala.query_options]
EXPLAIN_LEVEL=2
MT_DOP=2

A similar config group could be created for variables too.

If we decide to do it this way, then we should also change the overwrite behavior, because
config groups are typically not overwritten as whole, but as separate configs.


http://gerrit.cloudera.org:8080/#/c/8038/1/shell/option_parser.py
File shell/option_parser.py:

PS1, Line 160:   parser.add_option("--var", dest="keyval", action="append",
             :                     help="Define variable(s) to be used within the Impala session."
             :                          " It must follow the pattern \"KEY=VALUE\","
             :                          " KEY starts with an alphabetic character and"
             :                          " contains alphanumeric characters or underscores.")
             :   parser.add_option("--query_options", dest="query_options",
             :                     help="Sets default query options. The format is comma separated"
             :   
> A little bit of bike-shedding:
We have talked about this with Lars, and decided to stick with the comma separated strings.


It is also an option to support both formats.


-- 
To view, visit http://gerrit.cloudera.org:8080/8038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26a3b67230c80a99bd246b6af205d558fec9a986
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Csaba Ringhofer <csringhofer@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringhofer@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message