impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
Date Wed, 13 Sep 2017 20:08:09 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5923: Print binary ID as hex in ChildQuery::Cancel()
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8050/1/be/src/service/child-query.cc
File be/src/service/child-query.cc:

Line 131:   const string& guid = hs2_handle_.operationId.guid;
> Why not use ImpalaServer::THandleIdentifierToTUniqueId() to convert to a TU
Thanks, I didn't know what one.


-- 
To view, visit http://gerrit.cloudera.org:8080/8050
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1a9516d5c03524e2585255700bb84e8a301a7ee
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message