impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pranay Singh (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1649 Pass precision to Print TCounterType::DOUBLE VALUE
Date Wed, 13 Sep 2017 18:15:19 GMT
Pranay Singh has uploaded a new patch set (#2).

Change subject: IMPALA-1649 Pass precision to Print TCounterType::DOUBLE_VALUE
......................................................................

IMPALA-1649 Pass precision to Print TCounterType::DOUBLE_VALUE

Fix: Current code uses reinterpret_cast for printing
     TCounterType::DOUBLE_VALUE, which is unsafe. It also uses a
     fixed precision, 2 for printing which may not be desirable.

     This change removes the usage of reinterpret_cast and provides
     an option to specify precision as an argument type to
     Print TCounterType::DOUBLE_VALUE.

Change-Id: Icc63d8a59bdf175341097df143798fb1a957d93f
---
M be/src/util/pretty-printer-test.cc
M be/src/util/pretty-printer.h
M be/src/util/runtime-profile.cc
3 files changed, 20 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/7725/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7725
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icc63d8a59bdf175341097df143798fb1a957d93f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Pranay Singh
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>

Mime
View raw message