impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5905: add script for all-build-options job
Date Wed, 13 Sep 2017 03:38:58 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-5905: add script for all-build-options job
......................................................................


Patch Set 2: Code-Review+2

(3 comments)

Can you add a note about ccache and ninja?

http://gerrit.cloudera.org:8080/#/c/8043/1/bin/all-build-options.sh
File bin/all-build-options.sh:

Line 1
> Yeah the jenkins/ subdirectory makes sense to me, there's a lot of junk in 
I named the Jenkins job "all-build-options". I'm OK with a name change of any sort, or leaving
it the same. Maybe "build-with-all-flag-combinations.sh"?


Line 21
Required the ninja build system and ccache to be installed, which are not strictly build requirements.


PS1, Line 35: 
            : 
            : 
            : 
            : 
            : 
            : 
> I just preserved this logic from the original Jenkins job script. I didn't 
One difference: if clean.sh fails in the call to buildall, that call fails but we continue
to test more build options. This way, if we can't clean, we just dies since all the remaining
calls to buildall.sh should also fail but will provide no additional information.


-- 
To view, visit http://gerrit.cloudera.org:8080/8043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e78f05c41e3ccd59af599b00e453e7f88b2bb34
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message