impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5597: Try casting targetExpr when building runtime filter plan
Date Wed, 13 Sep 2017 00:31:30 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5597: Try casting targetExpr when building runtime filter plan
......................................................................


Patch Set 3:

(4 comments)

lgtm after this round

http://gerrit.cloudera.org:8080/#/c/7949/3/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java:

Line 587:       } catch (IllegalStateException e) {
catch (Exception e)


Line 592:     // Types of targetExpr and srcExpr should be exactly the same since runtime
filter is
Types of targetExpr and srcExpr must be exactly the same since runtime filters are based on
hashing.


Line 597:       } catch (AnalysisException | IllegalArgumentException e) {
catch (Exception e)


http://gerrit.cloudera.org:8080/#/c/7949/2/testdata/workloads/functional-query/queries/QueryTest/joins.test
File testdata/workloads/functional-query/queries/QueryTest/joins.test:

Line 774
> Done. What does propagation mean here?
I agree "propagation" may be confusing. I think it refers to the fact we are "sprinkling"
runtime filters throughout the plan tree. I think it's more confusing than not (might be better
to rename in a separate patch).


-- 
To view, visit http://gerrit.cloudera.org:8080/7949
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d66673e280ce13cd3a514236c0c2ecbc50475a6
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tianyi Wang <twang@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <twang@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message