impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5736: Add impala-shell argument to set default query options
Date Tue, 12 Sep 2017 16:49:21 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5736: Add impala-shell argument to set default query options
......................................................................


Patch Set 1:

(1 comment)

Looks good to me, only a minor comment.

http://gerrit.cloudera.org:8080/#/c/8038/1/shell/impala_shell.py
File shell/impala_shell.py:

PS1, Line 1308: keyvals
Can you inline this?


-- 
To view, visit http://gerrit.cloudera.org:8080/8038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26a3b67230c80a99bd246b6af205d558fec9a986
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Csaba Ringhofer <csringhofer@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message