impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5912: fix crash in trunc(..., "WW") in release build
Date Mon, 11 Sep 2017 22:08:33 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5912: fix crash in trunc(..., "WW") in release build
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8015/1//COMMIT_MSG
Commit Message:

PS1, Line 23: Also remove other uses of references to temporary that were correct but
            : unnecessary given that the function returned a value and C++11
            : return value optimisation should kick in.
> I guess there's an element of taste to it. It definitely gets confusing.
Yeah, i wasn't trying to express an opinion. just noting that it's a common pattern.


-- 
To view, visit http://gerrit.cloudera.org:8080/8015
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5017518188f5025daa5040ca1943581a0675726
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarshall@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message