impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5199: prevent hang on empty row batch exchange
Date Mon, 11 Sep 2017 21:48:57 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5199: prevent hang on empty row batch exchange
......................................................................


Patch Set 2: Code-Review+1

Making these cases consistent makes sense to me.  Really, I think we need to eventually rethink
the whole parallel startup stuff, especially now that we have per-query execrpc, etc. It just
seems too fragile.  But in the mean time, I see no reason the eos and non-eos case inconsistent.

-- 
To view, visit http://gerrit.cloudera.org:8080/8005
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib370ebe44e3bb34d3f0fb9f05aa6386eb91c8645
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message