impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates
Date Fri, 08 Sep 2017 23:23:23 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-5881: Use native allocation while building catalog updates

Patch Set 13:

File be/src/catalog/

Line 171:     LOG(ERROR) << "Failed to free buffers. Leaked memory of size: "
> Failed to free buffer. (singular buffer)
File fe/src/main/java/org/apache/impala/service/

Line 155:         FileUtils.byteCountToDisplaySize(
> We have a PrintUtils.printBytes(), use that for consistency. Maybe we shoul
I promise I searched for this, couldn't find it  and hence used the FileUtils :)
File fe/src/main/java/org/apache/impala/thrift/

Line 23:  * methods.
> Mention that we have this wrapper so we can override the methods for a test

Line 29:   public long allocate(long bufferPtr, long size) {
> reallocate()
File fe/src/main/java/org/apache/impala/thrift/

Line 92:   public  NativeByteArrayOutputStream() { this(new NativeAllocator()); }
> extra space after public

Line 103:       if (len <= 0) {
> Is this dead code? Not sure we can ever get here (how would we write a test
Yes, this is dead code, just retained for completeness. Should I remove? don't think we can
exercise this using tests.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I383684effa9524734ce3c6c0fb7ed37de0e15782
Gerrit-PatchSet: 13
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Bharath Vissapragada <>
Gerrit-Reviewer: Dimitris Tsirogiannis <>
Gerrit-Reviewer: Mostafa Mokhtar <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message