impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()
Date Fri, 08 Sep 2017 22:26:47 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4513: Promote integer types for ABS()
......................................................................


Patch Set 5:

test_exprs failed:


22:20:21 ]  TestExprs.test_exprs[exec_option: {'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold':
0, 'disable_codegen': False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} |
table_format: text/none | enable_expr_rewrites: 1] 
22:20:21 ] [gw9] linux2 -- Python 2.7.12 /home/ubuntu/Impala/bin/../infra/python/env/bin/python
22:20:21 ] query_test/test_exprs.py:58: in test_exprs
22:20:21 ]     self.run_test_case('QueryTest/exprs', vector)
22:20:21 ] common/impala_test_suite.py:419: in run_test_case
22:20:21 ]     self.__verify_results_and_errors(vector, test_section, result, use_db)
22:20:21 ] common/impala_test_suite.py:292: in __verify_results_and_errors
22:20:21 ]     replace_filenames_with_placeholder)
22:20:21 ] common/test_result_verifier.py:348: in verify_raw_results
22:20:21 ]     verify_results(expected_types, actual_types, order_matters=True)
22:20:21 ] common/test_result_verifier.py:258: in verify_results
22:20:21 ]     assert expected_results == actual_results
22:20:21 ] E   assert ['INT', 'SMAL... 'FLOAT', ...] == ['BIGINT', 'IN... 'FLOAT', ...]
22:20:21 ] E     At index 0 diff: 'INT' != 'BIGINT'
22:20:21 ] E     Use -v to get the full diff

-- 
To view, visit http://gerrit.cloudera.org:8080/8004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86cc880e78258d5f90471bd8af4caeb4305eed77
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message