impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitris Tsirogiannis (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates
Date Fri, 08 Sep 2017 22:10:01 GMT
Dimitris Tsirogiannis has posted comments on this change.

Change subject: IMPALA-5881: Use native allocation while building catalog updates
......................................................................


Patch Set 13:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7955/13/fe/src/main/java/org/apache/impala/thrift/NativeByteArrayOutputStream.java
File fe/src/main/java/org/apache/impala/thrift/NativeByteArrayOutputStream.java:

PS13, Line 100: private void tryAllocate(long len) {
              :     Preconditions.checkState(bufferPtr_ >= 0);
              :     try {
              :       if (len <= 0) {
              :         throw new IllegalArgumentException(INVALID_BUFFER_LEN_MSG + ": " +
len);
              :       }
              :       if (len >= BUFFER_MAX_SIZE_LIMIT) {
              :         throw new IllegalArgumentException(BUFFER_LIMIT_EXCEEDED_MSG + ":
" + len);
              :       }
              :       long newBufferPtr = nativeAllocator_.allocate(bufferPtr_, len);
              :       if (newBufferPtr == 0) {
              :         throw new IllegalStateException(ALLOCATION_FAILED_MSG + ": " + len
              :             + " Is realloc: " + (bufferPtr_ > 0));
              :       }
              :       bufferPtr_ = newBufferPtr;
              :       bufferLen_ = len;
              :     } catch (Throwable e) {
              :       nativeAllocator_.free(bufferPtr_);
              :       throw e;
              :     }
              :   }
I think that belongs to the Allocator class.


http://gerrit.cloudera.org:8080/#/c/7955/13/fe/src/test/java/org/apache/impala/thrift/NativeByteArrayOutputStreamTest.java
File fe/src/test/java/org/apache/impala/thrift/NativeByteArrayOutputStreamTest.java:

PS13, Line 43: return 0;
Shouldn't the allocate throw an OutOfMemoryException as well?


-- 
To view, visit http://gerrit.cloudera.org:8080/7955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I383684effa9524734ce3c6c0fb7ed37de0e15782
Gerrit-PatchSet: 13
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message