impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5211: Simplifying ifnull conditional.
Date Thu, 07 Sep 2017 00:03:08 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5211: Simplifying ifnull conditional.
......................................................................


Patch Set 5:

* Correct! The BE code and all the associated function plumbing for IFNULL should be removed.
* We should do the transformation even before analysis, like we do for  NVL2 (see FunctionCallExpr#createExpr).
I don't think we can get into a weird situation with NullLiterals.

I like your idea of handling "[not] distinct from" in a separate rule.

I agree that the docs are wrong, I'll let you decide whether to file a JIRA or fix it yourself.

-- 
To view, visit http://gerrit.cloudera.org:8080/7829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id91ca968a0c0be44e1ec54ad8602f91a5cb2e0e5
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message