impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-5902: add ThreadSanitizer build
Date Wed, 06 Sep 2017 20:59:32 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5902: add ThreadSanitizer build

Patch Set 1:

File be/src/common/

Line 142:       // The metric is refreshed whenever memory is consumed or released via a MemTracker,
A while back I changed the Process MemTracker under ASAN to use a metric. This makes it reasonable
to call this.

Line 199: #ifndef THREAD_SANITIZER
> Why can't we run this with TSAN? Should the #ifndef go inside that function
There are alternative implementations of the atomic ops for TSAN. That function is not even
compiled under TSAN.
File be/src/runtime/

Line 115:   // tcmalloc and address sanitizer cannot be used together
> nit: "or thread"
File be/src/util/

Line 139:   ss << "Memory tracking is not available with address sanitizer builds.";
> nit: "or thread"
File be/src/util/

PS1, Line 86: asan
> naming?
File be/src/util/memory-metrics.h:

Line 136: /// Alternative to TCMallocMetric if we're running under Address Sanitizer, which
> Naming?
File bin/

PS1, Line 104: 7
> How did you pick 7?
7 is the maximum value. I saw a few instances where the errors didn't include all info because
it was aged otu of the history.

I guess I should use the same for the other daemons too for consistency.
File tests/common/

Line 135:     either compiled with code coverage enabled or a sanitizer.
> except ubsan
I wasn't sure if UBSAN was just missing from this file - is it just treated as a normal debug

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I22f8faeefa5e157279c5973fe28bc573b7606d50
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message