impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2107: [DOCS] Document base64*code() functions
Date Wed, 06 Sep 2017 18:05:19 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-2107: [DOCS] Document base64*code() functions
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7963/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

Line 802:         <codeph>MAX()</codeph>, and <codeph>MIN()</codeph>
than when
Are you sure about MAX and MIN? They might preserve ordering. I don't know.


PS1, Line 808: All argument values
             :         supplied to <codeph>base64encode()</codeph> must also be
a
             :         multiple of 4 bytes in length.
I don't think this is right. The example you give below, for instance, is 'hello world', which
is 11 characters.

Did you mean that all arguments to base64decode must be a multiple of 4 bytes in length?


http://gerrit.cloudera.org:8080/#/c/7963/1/docs/topics/impala_string_functions.xml
File docs/topics/impala_string_functions.xml:

Line 88:       <dlentry id="base64decode" rev="2.9.0 IMPALA-2107">
This was fixed in 2.6.0, according to the ticket, not 2.9.0


-- 
To view, visit http://gerrit.cloudera.org:8080/7963
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5251e368ad36756c19a7b97e5ef6f232f616189b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message