impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5589: change "set" in impala-shell to show empty string for unset query options
Date Wed, 06 Sep 2017 15:37:03 GMT
Philip Zeyliger has posted comments on this change.

Change subject: IMPALA-5589: change "set" in impala-shell to show empty string for unset query
options
......................................................................


Patch Set 4:

My apologies! I failed to run some of the tests in my newbie-ness, and Gerrit/Jenkins caught
me guiltily and red-handed.

I think I've now fixed up "set.test" which triggered exactly as you'd expect. I just updated
it with the relevant new return values.

-- 
To view, visit http://gerrit.cloudera.org:8080/7886
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86bc06a58d67b099da911293202dae9e844c439b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Philip Zeyliger <philip@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message