impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5892: Allow reporting status independent of fragment instance
Date Wed, 06 Sep 2017 04:52:10 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-5892: Allow reporting status independent of fragment instance
......................................................................


Patch Set 2: Code-Review+2

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7943/2/be/src/runtime/coordinator-backend-state.cc
File be/src/runtime/coordinator-backend-state.cc:

Line 221:   DCHECK(requests_fragment_detail || omits_fragment_args);
how about just:

DCHECK_EQ(is_fragment_failure == nullptr, failed_instance_id == nullptr);

seems simpler to reason about rather than why the || condition is really xor.
(nit: If you do keep these bool's, remove the extraneous parenthesis from the rhs).


http://gerrit.cloudera.org:8080/#/c/7943/2/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

Line 873:   // in that case).  Coordinator fragment failed in this case so we log the query_id.
not your change (and doesn't have to be addressed now) but this comment doesn't seem to match
the code, right?


http://gerrit.cloudera.org:8080/#/c/7943/2/common/thrift/ImpalaInternalService.thrift
File common/thrift/ImpalaInternalService.thrift:

PS2, Line 613: =cdfklnoru
some random characters snuck in


-- 
To view, visit http://gerrit.cloudera.org:8080/7943
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4cd98022f1d62a999c7c80ff5474fa8d069eb12c
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <philip@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message