impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5812: NPE when x joining on const select having an empty result
Date Wed, 06 Sep 2017 03:47:02 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-5812: NPE when x joining on const select having an empty result
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7971/1//COMMIT_MSG
Commit Message:

Line 7: IMPALA-5812: NPE when x joining on const select having an empty result
Suggest:
Fix NPE when joining on empty const select


http://gerrit.cloudera.org:8080/#/c/7971/1/testdata/workloads/functional-planner/queries/PlannerTest/joins.test
File testdata/workloads/functional-planner/queries/PlannerTest/joins.test:

Line 2524: # IMPALA-5812: Test that a cross join with a constant select that returns an empty
result
Please move this into empty.test which tests various cases with EmptySetNode.


-- 
To view, visit http://gerrit.cloudera.org:8080/7971
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e425dbcb442aeeac687e103774823d3f50e6436
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bikramjeet Vig <bikramjeet.vig@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message