impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5885: free runtime filter allocations in Parquet
Date Tue, 05 Sep 2017 17:20:51 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5885: free runtime filter allocations in Parquet
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7931/3/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 1030:   FreeLocalAllocationsForConjuncts();
> do we still need the code at the end of HdfsScanNode::ScannerThread() that 
I don't think we do actually. The FreeLocalAllocations() call is unnecessary since Close()
does it anyway. The filter_status.ok() check is also unnecessary and incorrect since if some
filter ctxs were opened before the error, we still need to close them.

You can check to see if you agree.


-- 
To view, visit http://gerrit.cloudera.org:8080/7931
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecdda6af12d5ca578f7d2cb393e9cb9f49438f09
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message